[Code]Auto PM'er

**Artificial** · 30 Mar. 2010 03:23am

Originally Posted by Eternal Darkness

Code:

strURL = "http://www.gaiaonline.com/profile/privmsg.php"
  strReferer = "http://www.gaiaonline.com/profile/privmsg.php?mode=post"
  strPost = "username=" & _
  strRecipient & "&subject=" & _
  URLEncode(strTitle) & "&message=" & _
  URLEncode(strMessage) & "&area_code=&pn1=&pn2=&selected_options=post&btn_send=true&preview=&post=&mode=post&src=&folder=inbox&id="

It appears as if he is grabbing a bunch of the code in different 'GetWrappers'...

He doesn't need to 'Get' all that...

I did look at the code, I just don't see why you would add so many 'GetWrapper' 's to slightly shorten the 'PostWrapper' ...

Just stating the fact that it could be done more efficiently and with less code...

All he is doing is assigning the URL to post data, the referrer and post data to three different strings. He isn't using different GetWrappers at all. What he is doing is perfectly fine - I infact do it a lot when programming applications that interact with the web.

It seems more than anything that you're confused about what he's doing.

Code:

strPost = "blah" & strUsername & "blah"

All he is doing is instead of writing it on one line, spans it over multiple lines.

Code:

strPost = "blah" & _
strUsername & _
"blah"

There is nothing wrong with that, and it isn't more complicated.

30 Mar. 2010 03:47am

Originally Posted by Artificial

All he is doing is assigning the URL to post data, the referrer and post data to three different strings. He isn't using different GetWrappers at all. What he is doing is perfectly fine - I infact do it a lot when programming applications that interact with the web.

It seems more than anything that you're confused about what he's doing.

Code:

strPost = "blah" & strUsername & "blah"

All he is doing is instead of writing it on one line, spans it over multiple lines.

Code:

strPost = "blah" & _
strUsername & _
"blah"

There is nothing wrong with that, and it isn't more complicated.

It seem's more complicated than the way I coded it... Is all I am saying...

I see what he is doing perfectly fine... I just would do it like:

Code:

                StrHTML = Wrapper.GetWrapper("http://www.gaiaonline.com/profile/privmsg.php?mode=post")

                StrHTML = Wrapper.PostWrapper("http://www.gaiaonline.com/profile/privmsg.php", "username=" & lstaccounts.Items.Item(IntAcct) & "&subject=" & txtSubject.Text & "&message=" & txtMessage.Text & "&folder=inbox&mode=post&btn_send=true")

                If (InStr(1, StrHTML, "Your Private Message has been sent to: ")) Then
                    MsgBox("Message sent to : " & lstaccounts.SelectedItem)
                Else
                    MsgBox("Failed to send message...")
                End If

Simple, yet gets the job done... (From v1 of my pmer...)

Yes it is a personal preference, I understand that it may seem less complicated to you than to me, or vice a versa... I am simply expressing my opinion on the topic...

Thread: [Code]Auto PM'er

LinkBack

Thread Tools

Search Thread

Rate This Thread

Display

Hybrid View

Posting Permissions